Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] - Remove redundant column "channel" in conda_package_build table #994

Open
soapy1 opened this issue Nov 19, 2024 · 0 comments · May be fixed by #1010
Open

[MAINT] - Remove redundant column "channel" in conda_package_build table #994

soapy1 opened this issue Nov 19, 2024 · 0 comments · May be fixed by #1010

Comments

@soapy1
Copy link
Contributor

soapy1 commented Nov 19, 2024

Context

Follows up #961

Currently, the conda_package_build table has a column for the channel the package comes from (ref: https://github.com/conda-incubator/conda-store/blob/main/conda-store-server/conda_store_server/_internal/orm.py#L786). However, this is redundant information because each entry must also have a conda_package entry associated to it, which already has the channel information (https://github.com/conda-incubator/conda-store/blob/main/conda-store-server/conda_store_server/_internal/orm.py#L743).

This duplication of information can lead to inconsistencies, for example the bug resolved by #961.

Value and/or benefit

This change will simplify the database relations.

Anything else?

No response

@soapy1 soapy1 added needs: triaging 🚦 Someone needs to have a look at this issue and triage type: maintenance 🛠 labels Nov 19, 2024
@soapy1 soapy1 moved this from New 🚦 to TODO 📬 in conda-store 🐍 Nov 26, 2024
@soapy1 soapy1 removed the needs: triaging 🚦 Someone needs to have a look at this issue and triage label Dec 4, 2024
@soapy1 soapy1 moved this from TODO 📬 to In Progress 🏗 in conda-store 🐍 Dec 5, 2024
@soapy1 soapy1 linked a pull request Dec 5, 2024 that will close this issue
3 tasks
@soapy1 soapy1 moved this from In Progress 🏗 to In review 👀 in conda-store 🐍 Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In review 👀
Development

Successfully merging a pull request may close this issue.

1 participant