Fix CSE transformer #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: this passes al tests on my machine. @miklos1 can we check and merge this ASAP ? thanks |
|
It would be really nice though if you could make test cases from the reported examples, so that these bugs would not return. |
miklos1
added a commit
that referenced
this pull request
Aug 4, 2016
* fix-uninitialized: Add UnexpectedNode exception Handle any AST when attempting to remove zeros cse: Handle bilinear temporaries properly cse: Strengthen pushability check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miklos1 : finishing to run the firedrake tests now. If they all pass, we should merge this asap
fixes #88, fixes #87