Some MUC improvements #3583
Merged
Some MUC improvements #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't show the bookmarked icon in the header. - Don't use the `name` from the bookmark, since Converse doesn't let you set the bookmark name and using it adds complexity. - While refreshing the disco, set the MUC name - Remove ability to add/remove bookmark from the rooms list
jcbrand
force-pushed
the
jcbrand/muc-improvements
branch
from
87d1189 to
7fdb5be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namefrom the bookmark, since Converse doesn't let you set the bookmark name and using it adds complexity.