Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: claim ('exp') is too far in the future #4702

Open
astrooom opened this issue Dec 29, 2024 · 2 comments
Open

[Bug]: claim ('exp') is too far in the future #4702

astrooom opened this issue Dec 29, 2024 · 2 comments
Labels
🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization.

Comments

@astrooom
Copy link

astrooom commented Dec 29, 2024

Error Message and Logs

When deploying resources which have a private GitHub source created from the Private Repository (with GitHub App) option, this error often appears almost immediately after triggering the deployment:

2024-Dec-29 20:49:09.796095 Starting deployment of monorepo:wings:staging:mightywings to node-staging-mightywings.
2024-Dec-29 20:49:10.507605 Preparing container with helper image: ghcr.io/coollabsio/coolify-helper:1.0.4.
2024-Dec-29 20:49:10.914382 docker rm -f vo4c0g4kc8ow80804o884gg4
2024-Dec-29 20:49:10.914382 Error response from daemon: No such container: vo4c0g4kc8ow80804o884gg4
2024-Dec-29 20:49:11.290012 docker run -d --network coolify --name vo4c0g4kc8ow80804o884gg4 --rm -v /var/run/docker.sock:/var/run/docker.sock ghcr.io/coollabsio/coolify-helper:1.0.4
2024-Dec-29 20:49:11.290012 52dd64d762720394ff9fd2218ce6ae58aeb6efdb15688f1a33002ae2313ff2d5
2024-Dec-29 20:49:14.233401 Oops something is not okay, are you okay? 😢
2024-Dec-29 20:49:14.235961 Failed to get access token for GITHUB_APP_NAME with error: 'Expiration time' claim ('exp') is too far in the future

By "often appears", what I mean is it does not appear on every deployment. Sometimes it works just fine. It appears more frequently after not having deployed using the Github App for a long period of time.

My organization have been using Coolify for about 4 months and this error has only started appearing since about a month back. It seems like it's related to the GitHub app secret expiring. I will try dig up more information and update this task if I'm able to find any.

Steps to Reproduce

  1. Create a Resource and select the Private Repository (with GitHubApp) option
  2. Trigger a deployment of said service

Example Repository URL

No response

Coolify Version

v4.0.0-beta.380

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

Debian 12

Additional Information

No response

@astrooom astrooom added 🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization. labels Dec 29, 2024
@astrooom astrooom changed the title [Bug]: [Bug]: claim ('exp') is too far in the future Dec 29, 2024
@astrooom
Copy link
Author

astrooom commented Dec 29, 2024

I've noticed the same error message also appears when syncing the Github App Name at coolify_url/source/github/app_id

Failed to fetch GitHub App information: 'Expiration time' claim ('exp') is too far in the future

@astrooom
Copy link
Author

astrooom commented Dec 29, 2024

Ok, this is super strange. After setting my Coolify VPS to exactly match the time of GitHubs API, using:

sudo date +%T -s $(curl -sI https://api.github.com | grep -Fi "date" | awk '{ print $6 }') -u

the exp error no longer appears. This is even though I had UTC set as my system date this whole time. I even re-synced the system time to UTC a couple times to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization.
Projects
None yet
Development

No branches or pull requests

1 participant