Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A detailed CSV of the organization #641

Closed
wants to merge 3 commits into from

Conversation

franpb14
Copy link
Collaborator

As agreed with @sseerrggii, the administrator can download a detailed CSV and will be able to obtain all the information shown in this table. The "locale" and "balance" attributes of members and the "id" attribute of posts have also been deleted from the "friendly" reports.

Here you can see a demo.

Issue596_CSV_detailed.mp4

closes #596.

franpb14 added 3 commits May 22, 2021 17:35
…ding

A single CSV to allow easy linking. 3 attributes have also been removed from the other reports. Issue #596.
I've also adapted the tests of members and offers decorators. Issue #596.
@franpb14 franpb14 requested a review from markets May 23, 2021 12:14
@markets
Copy link
Collaborator

markets commented Jun 15, 2021

@sseerrggii @franpb14 sorry 🙏🏼 but IMHO this is too much 😛 I'd try to go with a more simple approach, like adding the missing (and relevant) attributes (pretty sure we are so close to that scenario) to the current reports and leave only the "Download All" to download all reports.

Another point, the Account model is very coupled to a user/member (or an organization). I'd say this is an implementation detail, but probably isn't necessary to expose it to the final user, so having for example the balance listed in the Members report makes sense from a user POV. Actually, the Account concept doesn't appear in the current app.

To summarize, my proposal is: tune (add/remove/update) current reports and 🚀 . @sseerrggii what attributes are you missing from current reports?

What do you think guys?

@franpb14
Copy link
Collaborator Author

I used this table to talk with @sseerrggii which attributes to use in the report, you both could use something similar to discuss what to put in the reports. I'm fine with changing it as you see fit.

@markets
Copy link
Collaborator

markets commented Jun 16, 2021

Yes @franpb14 and thank you so much for working on this!

@sseerrggii do you think we can simplify this task a bit 🙏🏼 ? you can check some reasons above #641 (comment)

I really think the current status (this branch I mean) overlaps a bit with current functionality, exposes implementation details and is not so DRY. Maybe am I missing something 🤔 ?

@sseerrggii
Copy link
Contributor

Iep! The problem is the purpose of reports and detailed CSV are different.

Admins use reports for print members/offers and give the printed version to users that have some troubles to use the platform, like older people. So we want to keep this reports really simple and comprehensible for this purpose.

Insted admins will use detailed CSV to extract information about their organization that now they can't get from statistics section, for example:

  • Last month transfers grouped by gender
  • New members of last year grouped by age
  • Count of groupal offers of last month
  • etc

For these reasons we thought on this solution, like "export your organization data" and do you own analysis outside the app

Anyway we could live without this feature 😉 there are a few admins that asked for that... So it's you decision @markets

From my point of view it's a way to keep the app simple and offer the option to export all data of your organization for organizations who want to do something with their data.

@markets
Copy link
Collaborator

markets commented Jun 17, 2021

ah! ok @sseerrggii now I understand better the problem we want to solve here...

To be honest, I still think we can "solve" both features using current solution. I mean, I'm almost sure we already print all relevant attributes. We can add the missing ones and the reports still are (IMHO) "understandable" for people with a less technology background.

Thanks for the info!

@sseerrggii
Copy link
Contributor

OK! What do you think if we close this PR for the moment and think in a better solution for the future?

@markets
Copy link
Collaborator

markets commented Jun 17, 2021

Yes! Sorry sorry 🙏🏼 there is too much tech debt in that branch. Let's think in a simpler way!

@sseerrggii sseerrggii closed this Jun 18, 2021
@markets markets deleted the feat/download-all-detailed branch September 21, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloadable organization data
3 participants