Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recipe sorter, ore dictionary support #306

Closed
wants to merge 1 commit into from
Closed

Fix recipe sorter, ore dictionary support #306

wants to merge 1 commit into from

Conversation

Adaptivity
Copy link
Contributor

Chests and crafting tabels were registered to have better compatibility with ganymedes01's WoodStuff mod. Also, closes #290

@copygirl Can you pull two my PRs and make a new release?

@copygirl
Copy link
Owner

I don't have anything set up to even build it, and I've given up responsibility. I'll leave it up to @Victorious3 and friends. Unless you want to go ahead and maintain it, feel free to release your fork to the public.

@Adaptivity
Copy link
Contributor Author

Maybe @Victorious3 can merge this too and make a new release then? I would appreciate this.

@Adaptivity
Copy link
Contributor Author

Oh, this should be used for reinforced chests... but I don't really know how to change chest recipes. Maybe you can leave this here, so maybe someone will add support for actual recipes later?

@copygirl
Copy link
Owner

I guess what should be done is checking the ore dictionary for whether the entry exists, and if not, just use chests instead. Might not work if mods add ore dictionary entries after BS registers their recipes though.

@Adaptivity
Copy link
Contributor Author

No reason to do checking. Better to register it, I've added support for a few mods (Buildcraft and Ender IO, as I remember) and it's working great.

@Adaptivity Adaptivity closed this Oct 25, 2015
@Adaptivity Adaptivity deleted the recipesorterfix branch October 25, 2015 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register PresentRecipe in RecipeSorter
2 participants