Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Schedule - Odds Partners #75

Closed
Btibert3 opened this issue Oct 25, 2024 · 3 comments · Fixed by #76
Closed

Get Schedule - Odds Partners #75

Btibert3 opened this issue Oct 25, 2024 · 3 comments · Fixed by #76

Comments

@Btibert3
Copy link

Describe the bug
Using the call from the README docs throws a Key Error for oddsPartners

To Reproduce
Steps to reproduce the behavior:

  1. pip install nhl-api-py
  2. from nhlpy import NHLClient
  3. client = NHLClient()
  4. games_test = client.schedule.get_schedule(date="2021-01-13") throws the error

Expected behavior
The call to complete successfully

Screenshots

image

Desktop (please complete the following information):

  • OS: Google Colab

Additional context
Add any other context about the problem here.

@coreyjs
Copy link
Owner

coreyjs commented Oct 27, 2024

Ah, edge case, no odds going back that far. I'll have a fix in shortly.

@coreyjs coreyjs linked a pull request Oct 27, 2024 that will close this issue
@coreyjs coreyjs mentioned this issue Oct 27, 2024
@coreyjs
Copy link
Owner

coreyjs commented Oct 27, 2024

Thanks for reporting this, I really do appreciate it. Fix is in version 2.12.1

@Btibert3
Copy link
Author

Amazing, thank you for such a fast turnaround. I haven't had much time to dive into the codebase, so I apologize for just lobbing tickets over the wall. This resulted from me mapping out an idea for a course I am running next semester, which would revolve around the need to get all game ids for a season, and then grab/parse the PBP data.

Thank you for your hard work on this library, I know it's a tall task to pull all of this together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants