-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit max size of payloads #7629
Labels
Comments
Ref relevant spec issue cosmos/ibc#1160 (though spec would in theory only mention implementations could opt to add limits, so hashing out what these look like is ibc-go level discussion) |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To avoid DDOS scenarios with IBC, we should limit the maximum size of packets by limiting the payload size. We should do this for both v1 and v2 packets.
We will set the max limit to 262144 bytes.
For v1, we can check the data size in
modules/core/04-channel/keeper/packet.go
:SendPacket
andRecvPacket
.For v2, we can check the total packets total payload size (sum packet.payloads sizes) in
modules/core/04-channel/v2/keeper/msg_server.go
:SendPacket
andRecvPacket
.The text was updated successfully, but these errors were encountered: