From c8dd23b5356e179377e34cb986098a965d25816c Mon Sep 17 00:00:00 2001 From: Danny Gauthier Date: Mon, 10 Feb 2025 08:37:17 -0500 Subject: [PATCH] fix(answerConfigurationId): remove internal tag (#4922) https://coveord.atlassian.net/browse/SVCC-4631 As we are releasing the KnowledgeHub and the Answer manager. It is now legitimate to show this property on the Quantic an Atomic Generate Answer components. --- .../atomic-angular/src/lib/stencil-generated/components.ts | 4 ++-- packages/atomic/src/components.d.ts | 6 ++++++ .../atomic-generated-answer/atomic-generated-answer.tsx | 1 - .../lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/packages/atomic-angular/projects/atomic-angular/src/lib/stencil-generated/components.ts b/packages/atomic-angular/projects/atomic-angular/src/lib/stencil-generated/components.ts index 0187e732e3d..dd1b7cbb9af 100644 --- a/packages/atomic-angular/projects/atomic-angular/src/lib/stencil-generated/components.ts +++ b/packages/atomic-angular/projects/atomic-angular/src/lib/stencil-generated/components.ts @@ -984,14 +984,14 @@ export declare interface AtomicFormatUnit extends Components.AtomicFormatUnit {} @ProxyCmp({ - inputs: ['collapsible', 'maxCollapsedHeight', 'tabsExcluded', 'tabsIncluded', 'withToggle'] + inputs: ['answerConfigurationId', 'collapsible', 'maxCollapsedHeight', 'tabsExcluded', 'tabsIncluded', 'withToggle'] }) @Component({ selector: 'atomic-generated-answer', changeDetection: ChangeDetectionStrategy.OnPush, template: '', // eslint-disable-next-line @angular-eslint/no-inputs-metadata-property - inputs: ['collapsible', 'maxCollapsedHeight', 'tabsExcluded', 'tabsIncluded', 'withToggle'], + inputs: ['answerConfigurationId', 'collapsible', 'maxCollapsedHeight', 'tabsExcluded', 'tabsIncluded', 'withToggle'], }) export class AtomicGeneratedAnswer { protected el: HTMLElement; diff --git a/packages/atomic/src/components.d.ts b/packages/atomic/src/components.d.ts index 3db7c908033..ee0cadd3f43 100644 --- a/packages/atomic/src/components.d.ts +++ b/packages/atomic/src/components.d.ts @@ -1081,6 +1081,9 @@ export namespace Components { * For more information, see [About Relevance Generative Answering (RGA)](https://docs.coveo.com/en/n9de0370/) */ interface AtomicGeneratedAnswer { + /** + * The unique identifier of the answer configuration to use to generate the answer. + */ "answerConfigurationId"?: string; /** * Whether to allow the answer to be collapsed when the text is taller than the specified `--atomic-crga-collapsed-height` value (16rem by default). @@ -7273,6 +7276,9 @@ declare namespace LocalJSX { * For more information, see [About Relevance Generative Answering (RGA)](https://docs.coveo.com/en/n9de0370/) */ interface AtomicGeneratedAnswer { + /** + * The unique identifier of the answer configuration to use to generate the answer. + */ "answerConfigurationId"?: string; /** * Whether to allow the answer to be collapsed when the text is taller than the specified `--atomic-crga-collapsed-height` value (16rem by default). diff --git a/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx b/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx index 0f78fa09203..ab4ec8bfb2e 100644 --- a/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx +++ b/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx @@ -121,7 +121,6 @@ export class AtomicGeneratedAnswer implements InitializableComponent { @Prop() maxCollapsedHeight = this.DEFAULT_COLLAPSED_HEIGHT; /** - * @internal * The unique identifier of the answer configuration to use to generate the answer. */ @Prop() answerConfigurationId?: string; diff --git a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js index 4fe060dd060..dc9cecbcb19 100644 --- a/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js +++ b/packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js @@ -85,8 +85,8 @@ export default class QuanticGeneratedAnswer extends LightningElement { */ @api withToggle = false; /** - * @internal * The unique identifier of the answer configuration to use to generate the answer. + * @api * @type {string} */ @api answerConfigurationId;