From 812912eb8a558339abc5cb974aa849b746d3dce6 Mon Sep 17 00:00:00 2001
From: Jonathan Leitschuh <jonathan.leitschuh@gmail.com>
Date: Fri, 20 Dec 2024 10:40:41 -0500
Subject: [PATCH] vuln-fix: Use HTTPS instead of HTTP to resolve deps
 CVE-2021-26291 (#8)

This fixes a security vulnerability in this project where the `pom.xml`
files were configuring Maven to resolve dependencies over HTTP instead of
HTTPS.

Weakness: CWE-829: Inclusion of Functionality from Untrusted Control Sphere
Severity: High
CVSS: 8.1
Detection: CodeQL & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>


Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8
Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-maven-non-https-url/) & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>


Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8


Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/IfHkrYfxx?organizationId=QWxsIEdpdEh1Yg%3D%3D

Co-authored-by: Moderne <team@moderne.io>
---
 activemq-test-atomikos/pom.xml | 2 +-
 activemq-web-console/pom.xml   | 2 +-
 pom.xml                        | 8 ++++----
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/activemq-test-atomikos/pom.xml b/activemq-test-atomikos/pom.xml
index a0ec60d..bd7ff77 100644
--- a/activemq-test-atomikos/pom.xml
+++ b/activemq-test-atomikos/pom.xml
@@ -42,7 +42,7 @@
     <!-- for the Atomikos jars -->
     <repository>
       <id>logicblaze.deps</id>
-      <url>http://repo.logicblaze.com/maven2-all</url>
+      <url>https://repo.logicblaze.com/maven2-all</url>
       <snapshots>
         <enabled>true</enabled>
       </snapshots>
diff --git a/activemq-web-console/pom.xml b/activemq-web-console/pom.xml
index 5499fd0..0c90f56 100644
--- a/activemq-web-console/pom.xml
+++ b/activemq-web-console/pom.xml
@@ -63,7 +63,7 @@
     <pluginRepository>
       <id>mortbay-repo</id>
       <name>mortbay-repo</name>
-      <url>http://www.mortbay.org/maven2/snapshot</url>
+      <url>https://www.mortbay.org/maven2/snapshot</url>
     </pluginRepository>
   </pluginRepositories>
 
diff --git a/pom.xml b/pom.xml
index 26adb57..907b844 100644
--- a/pom.xml
+++ b/pom.xml
@@ -76,12 +76,12 @@
     <repository>
       <id>apache.incubating.releases</id>
       <name>Apache Incubating Release Distribution Repository</name>
-      <url>http://people.apache.org/repo/m2-incubating-repository</url>
+      <url>https://people.apache.org/repo/m2-incubating-repository</url>
     </repository>
     <repository>
       <id>apache.snapshots</id>
       <name>Apache Development Snapshot Repository</name>
-      <url>http://people.apache.org/repo/m2-snapshot-repository</url>
+      <url>https://people.apache.org/repo/m2-snapshot-repository</url>
       <releases>
         <enabled>false</enabled>
       </releases>
@@ -92,12 +92,12 @@
     <pluginRepository>
       <id>apache.incubating.releases</id>
       <name>Apache Incubating Release Distribution Repository</name>
-      <url>http://people.apache.org/repo/m2-incubating-repository</url>
+      <url>https://people.apache.org/repo/m2-incubating-repository</url>
     </pluginRepository>
     <pluginRepository>
       <id>apache.snapshots</id>
       <name>Apache Development Snapshot Repository</name>
-      <url>http://people.apache.org/repo/m2-snapshot-repository</url>
+      <url>https://people.apache.org/repo/m2-snapshot-repository</url>
       <releases>
         <enabled>false</enabled>
       </releases>