setPackage allows illegal version

[ebowman]

setPackage lets you set a version that fails silently at runtime. In particular, '-', '/', '~'. and '.' are illegal characters, but Builder.setPackage does not detect that and throw an exception. This leads to very cryptic failures later on. In particular, we versioned an RPM like "1.2.3-SNAPSHOT", and the RPM build correctly, and installed correctly, but failed silently at erase time. It took awhile to figure out what was going on; it would be great if redline would have detected that problem.

[fredcooke]

The maven plugin does this mapping, however it might be nicer for it to exist in the core library?

Also see: RiotGamesMinions/riot-redline-plugin#4

[craigwblake]

I'll take a look at incorporating this change as soon as I have time to dedicate to it.

[mbecker73]

Instead of throwing an Exception, should invalid characters be mapped to "+" or an empty string, as fredcooke is suggesting?

[craigwblake]

Well, let's start with flagging it as an error, then I can add the conversion to a "+" after that. Care to send a pull request for that commit? I'd grab it directly but I don't think that will keep the proper author/committer metadata.

[craigwblake]

This should be fixed in 1.1.15 release.