You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the UpWindowAngularComponent appends its modal element to the body using document.body.appendChild, but the component's rendering logic needs to be adjusted to remove and re-add the modal dynamically based on the isOpen state, to follow a more declarative and controlled approach.
Task:
Implement logic to conditionally append the modal to the body only when the isOpen signal is true.
Ensure the modal is removed from the DOM when isOpen is false, without leaving any dangling DOM elements.
Refactor the current ngAfterViewInit logic to properly manage the lifecycle of the modal element.
Update focus trap and keyboard interaction to remain functional after this change.
Acceptance Criteria:
Modal should only be appended to the DOM when it is open and fully removed when closed.
Focus trap, keyboard navigation (Tab, Shift+Tab, and Escape), and animations should continue to work seamlessly.
Confirm and cancel actions should function as before, closing the modal and removing it from the DOM.
Additional Notes:
This change is intended to clean up the current DOM manipulation approach and make the component's lifecycle management more predictable.
Please consider edge cases, such as rapid opening and closing of the modal, and ensure animations still play correctly.
The text was updated successfully, but these errors were encountered:
Currently, the
UpWindowAngularComponent
appends its modal element to the body usingdocument.body.appendChild
, but the component's rendering logic needs to be adjusted to remove and re-add the modal dynamically based on theisOpen
state, to follow a more declarative and controlled approach.Task:
isOpen
signal istrue
.isOpen
isfalse
, without leaving any dangling DOM elements.ngAfterViewInit
logic to properly manage the lifecycle of the modal element.Acceptance Criteria:
Tab
,Shift+Tab
, andEscape
), and animations should continue to work seamlessly.Additional Notes:
The text was updated successfully, but these errors were encountered: