Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

Support 'namespaces' for metrics #265

Open
iksaif opened this issue Apr 10, 2017 · 3 comments
Open

Support 'namespaces' for metrics #265

iksaif opened this issue Apr 10, 2017 · 3 comments

Comments

@iksaif
Copy link
Contributor

iksaif commented Apr 10, 2017

It would be useful to have namespaces for metrics, in particular for multi-tenancy. This would allow us to have usage (in bytes and points/sec) per namespace.

Implentation wise, for carbon we could probably reuse some of that https://github.com/criteo-forks/carbon/blob/master/lib/carbon/storage.py

For Graphite we could add a way to filter out things that are not in the current namespace, but that isn't super important for now.

@iksaif iksaif added this to the v0.9.0 milestone Apr 10, 2017
@dbxfb
Copy link
Contributor

dbxfb commented Apr 10, 2017

Since most users [citation needed] already have some sort of namespacing based on the first 1~3 elements of the metric paths (e.g. app.component, team.app.component, etc.),
maybe we could start by using a simple prefix tree, possibly with configurable depth?

It makes it low-cost to compute stats per node and merge them, as long as the only goal remains computing stats.

@iksaif
Copy link
Contributor Author

iksaif commented Apr 11, 2017

With have unfertonately both team.subsystem and bla.team.subsystem. It will make it hard to group by 'team' if we just look at the first three elements. (Unless we group usage for all the combinations of the first three elements, but that may be a lot)

@dbxfb
Copy link
Contributor

dbxfb commented Apr 11, 2017

We could take all the unique values of the 2~3 first path elements, and assign a type to them, and then combine stats :-)

@iksaif iksaif removed this from the v0.9.0 milestone Dec 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants