Welcome to Cryostat! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #760

Description of the change:

1. Uses the safeCloseRecording method in two places where it wasn't before. Without this, any target connection failure would throw an exception and cause an early return from the callsites, which could lead to unexpected behaviour like orphaned resources left behind. This is the real fix.
2. Extracts some constants. This is just some cleanup.
3. Sets the smoketest logging verbosity as an optional setting. This was previously increased from the default INFO level to ALL in all cases, but I found that this actually interfered with the smoketest operation at times due to the extremely high verbosity - actions like archiving recordings actually saw a performance degradation because every byte written out by Cryostat would be logged, which drastically slowed the I/O and could cause operations to time out.

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

1. Check out and build PR
2. ./smoketest.bash -Ot (pass -v one or two times to enable verbose logging)
3. On various targets, try creating recordings, stopping them, archiving them, etc. and ensure no "Clone of x" recordings appear