Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for @global #87

Open
jantimon opened this issue Dec 12, 2024 · 1 comment
Open

Add support for @global #87

jantimon opened this issue Dec 12, 2024 · 1 comment

Comments

@jantimon
Copy link
Contributor

There's a great proposal by @devongovett in css-modules/css-modules#390 to introduce an @global at-rule.

I believe it makes the code easier to read than :global and also helps in cases like #75 where :global lead to parsing errors.

@global {
  @keyframes fade {
    /* ... */
  }
}

Compared to the current approach:

@keyframes :global(fade) {
  /* ... */
}

What do you think about implementing this (in a backwards compatible way)?

@jaggli
Copy link

jaggli commented Dec 12, 2024

Oh that's so much more intuitive. I would really appreciate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants