Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpacking can write out of bounds for arrays and strings #36

Open
GoogleCodeExporter opened this issue Jul 7, 2015 · 0 comments
Open

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Generate binary .proto buffer with more elements than MAX_REPEATED_LEN in 
array
2. Unpack the binary buffer in the generated .c code
3. The code will write out of the array bounds. 

What is the expected output? What do you see instead?
The expected outcome would be some kind of error to be reported and the 
unpacking to stop. Instead the code destroys the memory in the application. 

Same thing with strings longer than MAX_STRING_LEN. 

What version of the product are you using? On what operating system?
1.0M2 on windows. 

Please provide any additional information below.


Original issue reported on code.google.com by [email protected] on 26 Mar 2013 at 8:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant