Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bigger messages #40

Open
GoogleCodeExporter opened this issue Jul 7, 2015 · 1 comment
Open

Support for bigger messages #40

GoogleCodeExporter opened this issue Jul 7, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

We are using this library, but our messages need bigger strings (~256 chars 
instead of 32).

When we changes MAX_STRING_LEN to 256, whenever a message's total size exceeds 
256, the reading will stop right after the current field is parsed.

The problem seems to be that in the Msg_read_delimited_from(...), this line:

    offset = read_raw_varint32(&size, _buffer, offset);

which then executes this:

    offset = read_raw_byte((char *)&result, _buffer, offset);
    if (result >= 0) {
        *tag = result;
        return offset;
    }

returns at most one byte.

Original issue reported on code.google.com by [email protected] on 27 May 2013 at 12:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant