From 1627e03da86fbe4429f52112f876ac955d3f2802 Mon Sep 17 00:00:00 2001 From: zzj <29055749+zjzh@users.noreply.github.com> Date: Tue, 8 Mar 2022 10:38:50 +0800 Subject: [PATCH] refactoring code with List Comprehension refactoring code with List Comprehension which is more pythonic, concise, readable and efficient --- chartpy/dashboard/sessionmanager.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/chartpy/dashboard/sessionmanager.py b/chartpy/dashboard/sessionmanager.py index cfbb796..a01ffad 100644 --- a/chartpy/dashboard/sessionmanager.py +++ b/chartpy/dashboard/sessionmanager.py @@ -473,12 +473,9 @@ def create_calculated_flags(self, prefix, lst=None, lst2=None): if lst2 is None: return lst - - lst3 = [] - - for i in lst2: - for j in lst: - lst3.append(j + '-' + i) + + lst3 = [j + '-' + i for i in lst2 for j in lst] + return lst3 @@ -505,4 +502,4 @@ def flatten_list_of_lists(self, list_of_lists): return rt - return list_of_lists \ No newline at end of file + return list_of_lists