Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

const.py wrong VAT for german & Cent as "Ct." instead of "c" #466

Open
typxxi opened this issue Jan 1, 2025 · 1 comment
Open

const.py wrong VAT for german & Cent as "Ct." instead of "c" #466

typxxi opened this issue Jan 1, 2025 · 1 comment

Comments

@typxxi
Copy link

typxxi commented Jan 1, 2025

1. wrong VAT in that const.py file line 126: german VAT is 0.19 and NOT 0.23

2. remove the line 125 in const.py which starts with "Unsure about tax rate, correct if wrong"

image

3. I also suggest to change the unit for Cents in line 131 from "c" to "Ct." a few lines below of the VAT issue

_CURRENTY_TO_CENTS = {"DKK": "Øre", "NOK": "Øre", "SEK": "Öre", "EUR": "Ct."}

image

4. german translation

{
    "config": {
        "title": "Nordpool",
        "step": {
            "user": {
                "title": "Nordpool Sensor",
                "description": "Nordpool Sensor konfigurieren",
                "data": {
                    "region": "Region",
                    "currency": "Währung",
                    "VAT": "inkl. Mehrwertsteuer",
                    "precision": "Rundungspräzision (Nachkommastellen)",
                    "low_price_cutoff": "Niedrigtarif Prozentsatz",
                    "price_in_cents": "Preis in Cent",
                    "price_type": "Energie Maßstab",
                    "additional_costs": "Berechnungsvorlage für weitere Kosten"
                }
            }
        },
        "error": {
            "name_exists": "Name existiert bereits",
            "invalid_template": "Die Vorlage ist unzulässig, bitte hier prüfen https://github.com/custom-components/nordpool"
        }
    }
}

Version of the custom_component: 0.0.17

Homeassistant version: 2024.12.5

Configuration

Describe the bug

german VAT is 0.19 and not 0.23
It has caused issues before and VAT 23% is still wrong and can hurt again later

Debug log

no debug cause it currently works, but it has caused a big issue in 0.0.15 when this section was part of sensor.py file
image

@typxxi typxxi changed the title const.py wrong VAT for german const.py wrong VAT for german & Cent as "Ct." instead of "c" Jan 1, 2025
@Hellowlol
Copy link
Collaborator

Please send a pr to use the German translation if you think it incorrect and for the vat rate.

I will keep the c as indicator for cents. There is no official rules for how it should be used but they suggested both c and Ct in the official documentation https://european-union.europa.eu/document/download/b9fdeae1-dc66-47a7-a902-fb941309e744_hr?filename=publication6336_en.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants