preserving original rotation for export-import in yolo oriented boxes #8891

Eldies · 2024-12-30T12:04:23Z

Motivation and context

fixes #8882
depend on cvat-ai/datumaro#72

How has this been tested?

Checklist

I submit my changes into the develop branch
I have created a changelog fragment
I have updated the documentation accordingly
I have added tests to cover my changes
I have linked related issues (see GitHub docs)
I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

Chores
- Updated datumaro dependency to a new commit hash in project requirements files.

coderabbitai · 2024-12-30T12:04:36Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request involves updating the datumaro package dependency in both cvat/requirements/base.in and cvat/requirements/base.txt files. The change specifically updates the Git commit hash from 232c175ef1f3b7e55bd5162353df9c86a8116fde to 79dd809a1dbcc9e932e2c87eac7ba6a568a14a59. This modification suggests a version update for the Datumaro package, which is likely to include bug fixes, improvements, or new features.

Changes

File	Change Summary
`cvat/requirements/base.in`	Updated `datumaro` package Git commit hash
`cvat/requirements/base.txt`	Updated `datumaro` package Git commit hash

Assessment against linked issues

Objective	Addressed	Explanation
Import datasets with rotated boxes [#8882]	❓	Cannot definitively determine if this specific issue is resolved without examining the actual code changes in Datumaro

Poem

🐰 Hop, hop, dependencies dance!
A new commit hash takes its stance
Datumaro leaps with grace so bright
Updating code with pure delight
Rabbits code with joyful might! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov-commenter · 2024-12-30T13:17:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.95%. Comparing base (5d22b66) to head (dc3c73d).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8891      +/-   ##
===========================================
+ Coverage    73.93%   73.95%   +0.01%     
===========================================
  Files          411      411              
  Lines        44223    44237      +14     
  Branches      3993     3993              
===========================================
+ Hits         32695    32714      +19     
+ Misses       11528    11523       -5

Components	Coverage Δ
cvat-ui	`78.41% <ø> (+0.01%)`	⬆️
cvat-server	`70.16% <100.00%> (+0.02%)`	⬆️

# Conflicts: # cvat/apps/dataset_manager/formats/coco.py # cvat/apps/dataset_manager/formats/cvat.py # cvat/apps/dataset_manager/formats/kitti.py # cvat/requirements/base.in # cvat/requirements/base.txt

zhiltsov-max · 2025-01-07T16:32:11Z

Please update changelog.

# Conflicts: # cvat/requirements/base.in # cvat/requirements/base.txt

sonarqubecloud · 2025-01-08T09:45:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

update datumaro

7e153e4

Eldies requested a review from Marishka17 as a code owner December 30, 2024 12:04

Eldies added 3 commits January 2, 2025 13:53

update datumaro

a0f884d

Merge branch 'refs/heads/develop' into dl/yolo-preserve-rotation

ddea4f3

update datumaro

e5ee778

Eldies requested a review from zhiltsov-max as a code owner January 3, 2025 09:39

Eldies added 3 commits January 3, 2025 13:42

update datumaro

ff5c93b

Merge branch 'refs/heads/develop' into dl/yolo-preserve-rotation

c2c8f51

# Conflicts: # cvat/apps/dataset_manager/formats/coco.py # cvat/apps/dataset_manager/formats/cvat.py # cvat/apps/dataset_manager/formats/kitti.py # cvat/requirements/base.in # cvat/requirements/base.txt

isort fix

a43d3dc

Eldies added 2 commits January 8, 2025 12:47

Merge branch 'refs/heads/develop' into dl/yolo-preserve-rotation

b8e8669

# Conflicts: # cvat/requirements/base.in # cvat/requirements/base.txt

changelog entry

edd31b3

Eldies requested a review from nmanovic as a code owner January 8, 2025 09:05

updating requirements

dc3c73d

zhiltsov-max approved these changes Jan 8, 2025

View reviewed changes

Eldies merged commit 331ff86 into develop Jan 8, 2025
35 checks passed

Eldies deleted the dl/yolo-preserve-rotation branch January 8, 2025 12:07

This was referenced Jan 9, 2025

Release v2.25.0 #8916

Closed

Release v2.25.0 #8918

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

preserving original rotation for export-import in yolo oriented boxes #8891

preserving original rotation for export-import in yolo oriented boxes #8891

Eldies commented Dec 30, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 30, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov-commenter commented Dec 30, 2024 •

edited

Loading

zhiltsov-max commented Jan 7, 2025

sonarqubecloud bot commented Jan 8, 2025

preserving original rotation for export-import in yolo oriented boxes #8891

preserving original rotation for export-import in yolo oriented boxes #8891

Conversation

Eldies commented Dec 30, 2024 • edited by coderabbitai bot Loading

Motivation and context

How has this been tested?

Checklist

License

Summary by CodeRabbit

coderabbitai bot commented Dec 30, 2024 • edited Loading

Review skipped

Walkthrough

Changes

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov-commenter commented Dec 30, 2024 • edited Loading

Codecov Report

zhiltsov-max commented Jan 7, 2025

sonarqubecloud bot commented Jan 8, 2025

Quality Gate passed

Eldies commented Dec 30, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov-commenter commented Dec 30, 2024 •

edited

Loading