Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results from code and hf demo is different for simple_radial model #12

Open
bbzh opened this issue Nov 26, 2024 · 1 comment
Open

Results from code and hf demo is different for simple_radial model #12

bbzh opened this issue Nov 26, 2024 · 1 comment

Comments

@bbzh
Copy link

bbzh commented Nov 26, 2024

Hi,

I observe that the result by running the code is generally worse than the one in hf demo for the simple_radial model.
As an example, the first one below is from hf while the second one is from running code.
I can get the same results for the simple_divisional model, though.
Can you check if the code is using the same parameters as in hf demo? Thank!

Screenshot 2024-11-25 at 5 10 57 PM Screenshot 2024-11-25 at 5 10 40 PM
@veichta
Copy link
Collaborator

veichta commented Nov 26, 2024

Thank you for pointing this out! Are you running the demo notebook? It uses weights trained on distorted images, while the Hugging Face demo always uses weights trained on pinhole images. This mismatch likely explains the difference in results for the simple_radial model.

For this image, the simple_divisional model is more appropriate, as it handles stronger distortions better. Additionally, for the simple_radial model, the estimated focal length dictates how strong of a distortion can be handled, which might be a limitation in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants