From cdd7fb0a04ad136abf293297b8f6491e9ed43d88 Mon Sep 17 00:00:00 2001 From: Paul-Edouard Sarlin Date: Thu, 20 Jul 2023 10:00:02 +0200 Subject: [PATCH] Skip pycolmap version check if dev (#286) --- hloc/__init__.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hloc/__init__.py b/hloc/__init__.py index 52eff7d7..32d6b664 100644 --- a/hloc/__init__.py +++ b/hloc/__init__.py @@ -21,9 +21,10 @@ logger.warning('pycolmap is not installed, some features may not work.') else: minimal_version = version.parse('0.3.0') - found_version = version.parse(getattr(pycolmap, '__version__')) - if found_version < minimal_version: - logger.warning( - 'hloc now requires pycolmap>=%s but found pycolmap==%s, ' - 'please upgrade with `pip install --upgrade pycolmap`', - minimal_version, found_version) + found_version = pycolmap.__version__ + if found_version != 'dev': + if version.parse(found_version) < minimal_version: + logger.warning( + 'hloc now requires pycolmap>=%s but found pycolmap==%s, ' + 'please upgrade with `pip install --upgrade pycolmap`', + minimal_version, found_version)