Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eMBPoll always returns success #8

Open
karlp opened this issue Aug 26, 2019 · 0 comments · May be fixed by #11
Open

eMBPoll always returns success #8

karlp opened this issue Aug 26, 2019 · 0 comments · May be fixed by #11

Comments

@karlp
Copy link

karlp commented Aug 26, 2019

It seems more appropriate that it return eStatus, rather than always returning success. This would have a chance for the caller to track that things have gone wrong.
karlp added a commit to etactica/freemodbus that referenced this issue Aug 26, 2019
@karlp
eMBPoll: return internal failures
b7e6879 
Status flags are returned by the internal peMBFrameReceiveCur and
peMBFrameSendCur handlers, but were being ignored, with the function
simply always returning MB_ENOERR unless the entire eMBState was
invalid.

This should allow better stats collecting from the outside of eMBPoll

Fixes: cwalter-at#8
Signed-off-by: Karl Palsson <[email protected]>
@karlp karlp linked a pull request Aug 26, 2019 that will close this issue
Open
karlp added a commit to etactica/freemodbus that referenced this issue Jun 9, 2022
@karlp
eMBPoll: return internal failures
0b57e80 
Status flags are returned by the internal peMBFrameReceiveCur and
peMBFrameSendCur handlers, but were being ignored, with the function
simply always returning MB_ENOERR unless the entire eMBState was
invalid.

This should allow better stats collecting from the outside of eMBPoll

Fixes: cwalter-at#8
Signed-off-by: Karl Palsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

eMBPoll: return internal failures etactica/freemodbus
1 participant
@karlp