Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PHP 8.4 Deprecation messages #213

Open
1 task done
guilhermeaiolfi opened this issue Dec 9, 2024 · 1 comment
Open
1 task done

[Bug]: PHP 8.4 Deprecation messages #213

guilhermeaiolfi opened this issue Dec 9, 2024 · 1 comment
Labels
status:to be verified Needs to be reproduced and validated.

Comments

@guilhermeaiolfi
Copy link
Contributor

No duplicates 🥲.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

Describe the bug

Hi, I'm trying PHP 8.4 for my application and getting those messages:

Deprecated: Cycle\Database\Driver\Driver::lastInsertID(): Implicitly marking parameter $sequence as nullable is deprecated, the explicit nullable type must be used instead in vendor\cycle\database\src\Driver\Driver.php on line 238

Deprecated: Cycle\Database\Driver\Driver::beginTransaction(): Implicitly marking parameter $isolationLevel as nullable is deprecated, the explicit nullable type must be used instead in vendor\cycle\database\src\Driver\Driver.php on line 259

Deprecated: Cycle\Database\Driver\DriverInterface::lastInsertID(): Implicitly marking parameter $sequence as nullable is deprecated, the explicit nullable type must be used instead in vendor\cycle\database\src\Driver\DriverInterface.php on line 179

Deprecated: Cycle\Database\Driver\DriverInterface::beginTransaction(): Implicitly marking parameter $isolationLevel as nullable is deprecated, the explicit nullable type must be used instead in vendor\cycle\database\src\Driver\DriverInterface.php on line 190

Is this a regression?

NO

To Reproduce

Just run any app that uses Cycle\Database in PHP 8.4

Expected behaviour

No messages

Media prove

No response

Database

No response

Your environment

  • OS: Any

Additional context

No response

@guilhermeaiolfi guilhermeaiolfi added the status:to be verified Needs to be reproduced and validated. label Dec 9, 2024
@guilhermeaiolfi guilhermeaiolfi changed the title [Bug]: PHP 8.4 Deprecation [Bug]: PHP 8.4 Deprecation messages Dec 9, 2024
@roxblnfk
Copy link
Member

roxblnfk commented Dec 9, 2024

Hello. I'm currently updating all the Spiral packages and will get to Cycle soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:to be verified Needs to be reproduced and validated.
Projects
None yet
Development

No branches or pull requests

2 participants