Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation warnings Rev3 #1508

Closed
5 of 7 tasks
MikeMcC399 opened this issue Feb 7, 2024 · 9 comments
Closed
5 of 7 tasks

Installation warnings Rev3 #1508

MikeMcC399 opened this issue Feb 7, 2024 · 9 comments
Labels
good-first-issue

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Feb 7, 2024 •
edited
Loading

Description

Running yarn install produces installation warnings. Resolved issues are ticked in the list below:

Steps to reproduce

Clone repo and execute the following under Node.js 18.16.1 20.11.0:

git clean -x -d -f
yarn install

Expectation

There should be no installation warnings produced by yarn install.

Logs

Clean install

$ node -v
v18.16.1

$ yarn
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning " > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "aws-amplify > @aws-amplify/core > [email protected]" has unmet peer dependency "react-native@*".
warning "aws-amplify > @aws-amplify/analytics > @aws-sdk/client-firehose > @aws-sdk/middleware-retry > [email protected]" has unmet peer dependency "react-native@>=0.56".
warning " > [email protected]" has incorrect peer dependency "react@^15.3.0 || ^16.0.0-alpha".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "[email protected] || 16.x".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "react@^15.0.0 || ^16.0.0".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "react-dom@^15.0.0 || ^16.0.0".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "react@^0.14.0 || ^15.0.0".
warning "@cypress/code-coverage > @cypress/[email protected]" has unmet peer dependency "@babel/preset-env@^7.0.0".
warning "@cypress/code-coverage > @cypress/[email protected]" has unmet peer dependency "babel-loader@^8.0.2 || ^9".
warning " > [email protected]" has incorrect peer dependency "graphql@^14.7.0 || ^15.3.0".
warning Workspaces can only be enabled in private projects.
[5/5] Building fresh packages...
$ husky install && patch-package
husky - Git hooks installed
patch-package 7.0.2
Applying patches...
@material-ui/[email protected] ✔
[email protected] ✔
Done in 461.33s.

Related issues
This was referenced Feb 7, 2024
Closed
Open
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane
Copy link
Member

We'd be open to PRs around these updates.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

We'd be open to PRs around these updates.

I don't have the skills to provide these updates, so there is no plan from my side to submit any PRs to resolve this issue. @astone123 was previously covering these points.

@astone123
Copy link
Contributor

@MikeMcC399 unfortunately, I don't think we'll have the bandwidth to prioritize this any time soon. If I have some free time, I'll try to look into this but I wouldn't count on it.

If you feel comfortable trying to fix these issues and open a partial PR, that might be a good starting point for us to work from, even if you can't resolve everything at once. Thanks

@MikeMcC399
Copy link
Contributor Author

@astone123

unfortunately, I don't think we'll have the bandwidth to prioritize this any time soon. If I have some free time, I'll try to look into this but I wouldn't count on it.

If you feel comfortable trying to fix these issues and open a partial PR, that might be a good starting point for us to work from, even if you can't resolve everything at once. Thanks

@MikeMcC399
Copy link
Contributor Author

timheilman added a commit to timheilman/cypress-realworld-app that referenced this issue Mar 5, 2024
@timheilman
build: replace express-graphql with graphql-http and graphql-playgrou…
a40c8de 
…nd-middleware-express

toward resolution of issue cypress-io#1420 and cypress-io#1508
This was referenced Mar 5, 2024
Merged
Merged
cacieprins added a commit that referenced this issue May 20, 2024
@timheilman @cacieprins
build: replace express-graphql with graphql-http and graphql-playgrou… (
cdd56ba 
#1521)

* build: replace express-graphql with graphql-http and graphql-playground-middleware-express

toward resolution of issue #1420 and #1508

* fix: go ahead and preempt provision of GET at /graphql by graphql-http

with graphql-playground-middleware-express, rather than serving it from GET /gql-playground. This preserves functionality closer to as it was with express-graphql.

* fix: whoops did not mean to modify database.json

* Update backend/app.ts

Co-authored-by: Cacie Prins <[email protected]>

* style: do not pollute type system with one-off inline types

* fix: consume rename commited on github from reviewer suggestion

* style: do not pollute Query.ts either with one-off inline types

* build: empty commit to clear perhaps spurious circleCI failure on firefox

all specs passing on firefox locally.

---------

Co-authored-by: Cacie Prins <[email protected]>
@MikeMcC399
Copy link
Contributor Author

markerikson pushed a commit to replayio-public/cypress-realworld-app that referenced this issue Jun 25, 2024
@timheilman @cacieprins @markerikson
build: replace express-graphql with graphql-http and graphql-playgrou… (
a2b7f05 
cypress-io#1521)

* build: replace express-graphql with graphql-http and graphql-playground-middleware-express

toward resolution of issue cypress-io#1420 and cypress-io#1508

* fix: go ahead and preempt provision of GET at /graphql by graphql-http

with graphql-playground-middleware-express, rather than serving it from GET /gql-playground. This preserves functionality closer to as it was with express-graphql.

* fix: whoops did not mean to modify database.json

* Update backend/app.ts

Co-authored-by: Cacie Prins <[email protected]>

* style: do not pollute type system with one-off inline types

* fix: consume rename commited on github from reviewer suggestion

* style: do not pollute Query.ts either with one-off inline types

* build: empty commit to clear perhaps spurious circleCI failure on firefox

all specs passing on firefox locally.

---------

Co-authored-by: Cacie Prins <[email protected]>
@MikeMcC399
Copy link
Contributor Author

@MikeMcC399
Copy link
Contributor Author

Closing this issue.

The remaining installation warnings are covered in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jennifer-shehane @astone123 @MikeMcC399