Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing embedded color profile information at the top for Display P3 images #2050

Open
AmeJunn opened this issue Nov 29, 2024 · 5 comments
Open
Labels

Comments

@AmeJunn
Copy link

AmeJunn commented Nov 29, 2024

System information

  • Windows OS version: Windows 10
  • ImageGlass version: 9.1.8.723 (64-bit)
  • ImageGlass release: Store / Classic? Classic

#############

To Reproduce

Steps to reproduce the behavior:

  1. Open image with a Display P3 embedded color profile
  2. Look at the top. It should be missing the "/Display P3" part

#############

Explanation

For some time I was wondering why ImageGlass was slightly saturating sRGB images on my sRGB monitor, because those images would show in ImageGlass:
Image Glass displays as sRGB

Later I saw an image that actually has an embedded sRGB profile and it displayed in ImageGlass:
Correct srgb

That's when I decided to see the correct embedded color profile of that first image by importing it on Photoshop and I saw:
embedded Display P3
The image isn't actually sRGB, it's Display P3. ImageGlass is displaying the wrong embedded color profile for Display P3 images. So that explains my confusion.

Expected behavior

ImageGlass should say "sRGB/Display P3" like it does for every other color profile, or images without color profile embedded:
example 1
example 2
example 3

#############

Additional context

Color management works perfectly as intended. It just displays the wrong embedded color profile at the top for Display P3 images

Thanks

@AmeJunn AmeJunn changed the title ImageGlass displays the wrong color profile for DCI-P3 embedded images Missing embedded color profile information at the top for DCI-P3 images Nov 29, 2024
@AmeJunn AmeJunn changed the title Missing embedded color profile information at the top for DCI-P3 images Missing embedded color profile information at the top for Display P3 images Nov 29, 2024
@d2phap
Copy link
Owner

d2phap commented Nov 29, 2024

@AmeJunn Could you attach a sample image?
The color profile value info provided by Magick.NET library, I will need to check it before forwarding the issue to them

@AmeJunn
Copy link
Author

AmeJunn commented Nov 29, 2024

Sure. Here is one:
example image Artist is hgreeee twitter
artist is hgreeee on twitter

@d2phap
Copy link
Owner

d2phap commented Nov 30, 2024

@AmeJunn the image above does not contain a color profile. Is it the original file?
Maybe you can compress it in ZIP format and upload here

@AmeJunn
Copy link
Author

AmeJunn commented Nov 30, 2024

@d2phap That is strange. I downloaded the image above just to be sure github didn't strip it. And it says in photoshop it is Display P3. How did you check for embedded color profile?
I don't have the original file because I am not the original artist, but I did make a ZIP file with a bunch of example images. With and without the problem. Also I made a .psd with the embedded profile from the image above. I have made some READ MEs inside to explain some stuff aswell.
Display P3 problem not showing name in ImageGlass and other examples.zip

Thanks

@AmeJunn
Copy link
Author

AmeJunn commented Nov 30, 2024

Also by the way. I assume the format displayed in ImageGlass is (monitor profile)/(image profile) right?
So if the images with the problem just show (monitor profile) and don't even have the "/" then I assume it's failing to read the image's color profile, so it's only displaying my monitor profile.
If the image didn't have an embedded color profile it would display (monitor profile)/- instead of just (monitor profile)
For example:
-correct:
sRGB/-
sRGB/Display P3
sRGB/sRGB IEC61966-2.1 (sRGB)
-wrong:
sRGB

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants