You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, let me thank you for this truly astonishing NuGet package!
I only wish I had discovered it a long time ago and saved myself countless hours of similar effort. That said, while exploring this extensive package, I did come across one minor documentation/commenting mistake.
In the PInvoke/Ole/Ole32/PropIdl.PROPVARIANT.cs module, in the PROPVARIANT structure, I believe there are a series of inaccurate comments. Specifically, these comments include the text "by value", which I believe should actually read "by reference".
As one example, among many instances, we see the following comment and field:
/// <summary>Gets the "by value" byte value.</summary>
public byte? pbVal => GetRawValue<byte>();
Elsewhere in the same module, where the pbVal field is used, we see the following code. From this code, we can see it is clearly a "by reference" byte value (see isRef/VARTYPE.VT_BYREF):
Thanks again for your amazing work! I look forward to continuing to explore this package.
Also, as I integrate it into my projects, I look forward to jettisoning a metric ton of similar P/Invoke code I wrote.
The text was updated successfully, but these errors were encountered:
CodeSetting
changed the title
Incorrect "is value" comments in PInvoke/Ole/Ole32/PropIdl.PROPVARIANT.cs PROPVARIANT structure
Incorrect "by value" comments in PInvoke/Ole/Ole32/PropIdl.PROPVARIANT.cs PROPVARIANT structure
Dec 23, 2024
First, let me thank you for this truly astonishing NuGet package!
I only wish I had discovered it a long time ago and saved myself countless hours of similar effort. That said, while exploring this extensive package, I did come across one minor documentation/commenting mistake.
In the PInvoke/Ole/Ole32/PropIdl.PROPVARIANT.cs module, in the
PROPVARIANT
structure, I believe there are a series of inaccurate comments. Specifically, these comments include the text "by value", which I believe should actually read "by reference".As one example, among many instances, we see the following comment and field:
Elsewhere in the same module, where the
pbVal
field is used, we see the following code. From this code, we can see it is clearly a "by reference" byte value (seeisRef
/VARTYPE.VT_BYREF
):Thanks again for your amazing work! I look forward to continuing to explore this package.
Also, as I integrate it into my projects, I look forward to jettisoning a metric ton of similar P/Invoke code I wrote.
The text was updated successfully, but these errors were encountered: