New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-memory challenge storage is leaking if the client requests a challenge and never comes back #1

Open

daniel-orlov opened this issue Jul 26, 2023 · 0 comments

Assignees

Labels

bug

Owner

daniel-orlov commented Jul 26, 2023

Describe the bug
The current implementation of the challenge storage is prone to memory leaks if operated during the long period of time.

To Reproduce
Steps to reproduce the behavior:

Run server with the standard config.
Request challenge by hitting any endpoint behind the Proofer middleware.
Repeat the step two from different IP addresses and don't come back with solutions.
The challenges stay in the storage until they are solved/server is stopped.

Expected behavior
Challenges have TTL and are cleaned up even if not solved

Screenshots
If applicable, add screenshots to help explain your problem.

How do you run the server (please complete the following information):

on OS: any OS
on arch: any arch
using User-Agent: any User-Agent

Additional context
This could be solved with TTL for in-memory starage and/or Redis

daniel-orlov added the bug label

daniel-orlov self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment