From e70fe5b4eb427fc14c211c58c2ba6c0a5e54aac7 Mon Sep 17 00:00:00 2001
From: fatkodima <fatkodima123@gmail.com>
Date: Fri, 18 Oct 2024 22:41:31 +0300
Subject: [PATCH] Do not swallow `config.ignore` regexp errors

---
 lib/coverband/configuration.rb       |  2 --
 test/coverband/configuration_test.rb | 10 ----------
 2 files changed, 12 deletions(-)

diff --git a/lib/coverband/configuration.rb b/lib/coverband/configuration.rb
index 99e11a29..f023413e 100644
--- a/lib/coverband/configuration.rb
+++ b/lib/coverband/configuration.rb
@@ -224,8 +224,6 @@ def search_paths=(path_array)
     def ignore=(ignored_array)
       ignored_array = ignored_array.map { |ignore_str| Regexp.new(ignore_str) }
       @ignore |= ignored_array
-    rescue RegexpError
-      logger.error "an invalid regular expression was passed in, ensure string are valid regex patterns #{ignored_array.join(",")}"
     end
 
     def current_root
diff --git a/test/coverband/configuration_test.rb b/test/coverband/configuration_test.rb
index 0259e663..ac040902 100644
--- a/test/coverband/configuration_test.rb
+++ b/test/coverband/configuration_test.rb
@@ -38,16 +38,6 @@ def setup
     assert_equal expected, Coverband.configuration.ignore
   end
 
-  test "ignore catches regex errors" do
-    Coverband.configuration.logger.expects(:error).with("an invalid regular expression was passed in, ensure string are valid regex patterns *invalidRegex*")
-    Coverband.configure do |config|
-      config.ignore = ["*invalidRegex*"]
-    end
-    Coverband::Collectors::Coverage.instance.reset_instance
-    expected = (Coverband::Configuration::IGNORE_DEFAULTS << "config/environments").map { |str| Regexp.new(str) }
-    assert_equal expected, Coverband.configuration.ignore
-  end
-
   test "ignore" do
     Coverband::Collectors::Coverage.instance.reset_instance
     assert !Coverband.configuration.ignore.first.nil?