From 74d9babf252ecd413acec8883b0c434380e09622 Mon Sep 17 00:00:00 2001 From: jrhoads Date: Mon, 12 Jun 2023 15:48:20 -0400 Subject: [PATCH 1/4] bump version of cypress action --- .github/workflows/cypress_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cypress_tests.yml b/.github/workflows/cypress_tests.yml index 8a19c29a..82f249d8 100644 --- a/.github/workflows/cypress_tests.yml +++ b/.github/workflows/cypress_tests.yml @@ -23,7 +23,7 @@ jobs: uses: actions/checkout@v3 - name: Cypress run - uses: cypress-io/github-action@v3 + uses: cypress-io/github-action@v5 with: start: yarn dev wait-on: 'http://localhost:3000' From 1cb23f941f32372a62dcd4dbfe38fb14c5a9e262 Mon Sep 17 00:00:00 2001 From: jrhoads Date: Mon, 12 Jun 2023 15:49:50 -0400 Subject: [PATCH 2/4] Use inherited secrets --- .github/workflows/pull_request.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 255f9142..83fc7d1a 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -6,7 +6,4 @@ on: jobs: test: uses: ./.github/workflows/cypress_tests.yml - secrets: - NEXT_PUBLIC_API_URL: ${{ secrets.NEXT_PUBLIC_API_URL }} - CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }} - CYPRESS_USER_COOKIE: ${{ secrets.CYPRESS_USER_COOKIE }} + secrets: inherit From e2e63b4d563885b2d5dbcfa5f0513d4a6dc8bc78 Mon Sep 17 00:00:00 2001 From: jrhoads Date: Mon, 12 Jun 2023 15:58:58 -0400 Subject: [PATCH 3/4] Specifiy node version to test under --- .github/workflows/cypress_tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/cypress_tests.yml b/.github/workflows/cypress_tests.yml index 82f249d8..2855c51c 100644 --- a/.github/workflows/cypress_tests.yml +++ b/.github/workflows/cypress_tests.yml @@ -25,6 +25,7 @@ jobs: - name: Cypress run uses: cypress-io/github-action@v5 with: + node-version: 18 start: yarn dev wait-on: 'http://localhost:3000' quiet: true From 4ba7412e8922c5508211ad96e41fc764bcad26a2 Mon Sep 17 00:00:00 2001 From: jrhoads Date: Mon, 12 Jun 2023 16:07:34 -0400 Subject: [PATCH 4/4] Explicitly set node-version --- .github/workflows/cypress_tests.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cypress_tests.yml b/.github/workflows/cypress_tests.yml index 2855c51c..b4254a4d 100644 --- a/.github/workflows/cypress_tests.yml +++ b/.github/workflows/cypress_tests.yml @@ -19,13 +19,14 @@ jobs: matrix: containers: [1, 2, 3, 4, 5] steps: + - uses: actions/setup-node@v3 + with: + node-version: 18 - name: Checkout uses: actions/checkout@v3 - - name: Cypress run uses: cypress-io/github-action@v5 with: - node-version: 18 start: yarn dev wait-on: 'http://localhost:3000' quiet: true