From 573d4b9a7dcc1a31fd1c3dbcb16ec58584b2136b Mon Sep 17 00:00:00 2001
From: Kristian Garza <kj.garza@gmail.com>
Date: Tue, 15 Oct 2019 18:41:08 +0200
Subject: [PATCH] fixes error wrong code

https://github.com/datacite/lupo/issues/264

creating a new DOI reuqires to have client id but that was is obtianed in safe_params which also doesn not require auth
---
 app/controllers/dois_controller.rb |  1 +
 spec/requests/dois_spec.rb         | 24 ++++++++++++++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/app/controllers/dois_controller.rb b/app/controllers/dois_controller.rb
index c12eb9762..ad1925445 100644
--- a/app/controllers/dois_controller.rb
+++ b/app/controllers/dois_controller.rb
@@ -291,6 +291,7 @@ def validate
   def create
     logger = Logger.new(STDOUT)
     # logger.info safe_params.inspect
+    fail CanCan::AuthorizationNotPerformed unless current_user.present?
 
     @doi = Doi.new(safe_params)
 
diff --git a/spec/requests/dois_spec.rb b/spec/requests/dois_spec.rb
index fbe290aff..bb5dcd927 100644
--- a/spec/requests/dois_spec.rb
+++ b/spec/requests/dois_spec.rb
@@ -966,6 +966,30 @@
       end
     end
 
+    context 'when the request is valid no password' do
+      let(:xml) { Base64.strict_encode64(file_fixture('datacite.xml').read) }
+      let(:valid_attributes) do
+        {
+          "data" => {
+            "type" => "dois",
+            "attributes" => {
+              "doi" => "10.14454/10703",
+              "url" => "http://www.bl.uk/pdf/patspec.pdf",
+              "xml" => xml,
+              "source" => "test",
+              "event" => "publish"
+            }
+          }
+        }
+      end
+
+      it 'fails to create a Doi' do
+        post '/dois', valid_attributes
+
+        expect(last_response.status).to eq(401)
+      end
+    end
+
     context 'when the request is valid random doi' do
       let(:xml) { Base64.strict_encode64(file_fixture('datacite.xml').read) }
       let(:valid_attributes) do