From 00445af449148c6a10f170e745f0c2271ca13d18 Mon Sep 17 00:00:00 2001 From: Kristian Garza Date: Mon, 14 Oct 2019 17:25:49 +0200 Subject: [PATCH] save only at the end or on error --- app/models/claim.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/claim.rb b/app/models/claim.rb index 9a31f58c..1db71828 100644 --- a/app/models/claim.rb +++ b/app/models/claim.rb @@ -185,13 +185,13 @@ def to_param # overridden, use uuid instead of id def process_data(options={}) logger = Logger.new(STDOUT) - self.start! + self.start ### depdency Injection for testing result = options[:collect_data] || collect_data if result.body["skip"] - claimed_at.present? ? self.finish! : self.skip! + claimed_at.present? ? self.finish : self.skip logger.warn "[Skipped] #{self.uid} – #{self.doi}] #{result.body["reason"]}" elsif result.body["errors"] @@ -209,7 +209,7 @@ def process_data(options={}) logger.warn "[Notification] #{self.uid} – #{self.doi}] with Put Code #{result.body["put_code"]}" - self.notify! + self.notify else if to_be_created? write_attribute(:claimed_at, Time.zone.now)