From eb391a7fdd4ec2a3dc81d0e34234529b7757690c Mon Sep 17 00:00:00 2001 From: niphlod Date: Fri, 16 Dec 2016 00:55:52 +0100 Subject: [PATCH 1/3] fix -Databases to be filled with unique values --- internal/DynamicParams.ps1 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/internal/DynamicParams.ps1 b/internal/DynamicParams.ps1 index 7828cac15e..953f489cb3 100644 --- a/internal/DynamicParams.ps1 +++ b/internal/DynamicParams.ps1 @@ -263,6 +263,8 @@ filled with snapshot list from specified SQL Server server. $databaselist += $database.DatabaseSnapshotBaseName } } + + $databaselist = $databaselist | Get-Unique # Reusable parameter setup $newparams = New-Object System.Management.Automation.RuntimeDefinedParameterDictionary From af02a34d35f974a90b898c874ee8d4fc3138c703 Mon Sep 17 00:00:00 2001 From: ctrlbold Date: Fri, 16 Dec 2016 01:19:36 +0100 Subject: [PATCH 2/3] fix parsing issue it needed to be split anyway --- functions/Test-DbaValidLogin.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/functions/Test-DbaValidLogin.ps1 b/functions/Test-DbaValidLogin.ps1 index 9cbb95e50d..244f4ae648 100644 --- a/functions/Test-DbaValidLogin.ps1 +++ b/functions/Test-DbaValidLogin.ps1 @@ -178,7 +178,7 @@ Tests all logins excluding any that are from the mydomain Domain $windowslogins = $allwindowsloginsgroups | Where-Object { $_.LoginType -eq 'WindowsUser' } $windowslogins = $windowslogins | Where-Object { $_.Name.StartsWith("NT ") -eq $false -and $_.Name.StartsWith($SqlServer) -eq $false -and $_.Name.StartsWith("BUILTIN") -eq $false } $windowsGroups = $allwindowsloginsgroups | Where-Object { $_.LoginType -eq 'WindowsGroup' } - $windowsGroups = $windowsGroups | Where-Object { $_.Name.StartsWith("NT ") -eq $false -and $_.Name -notmatch $SqlServer -and $_.Name.StartsWith("BUILTIN") -eq $false } + $windowsGroups = $windowsGroups | Where-Object { $_.Name.StartsWith("NT ") -eq $false -and $_.Name -notmatch $SqlServer.Split("\\")[0] -and $_.Name.StartsWith("BUILTIN") -eq $false } } } From 3fa4fc55ddcb56e63843981958f85b8eb5420d52 Mon Sep 17 00:00:00 2001 From: ctrlbold Date: Fri, 16 Dec 2016 01:29:07 +0100 Subject: [PATCH 3/3] upped version number, added releasenotes info --- dbatools.psd1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dbatools.psd1 b/dbatools.psd1 index d5e696ca4b..f830d7bd26 100644 --- a/dbatools.psd1 +++ b/dbatools.psd1 @@ -11,7 +11,7 @@ RootModule = 'dbatools.psm1' # Version number of this module. - ModuleVersion = '0.8.691' + ModuleVersion = '0.8.692' # ID used to uniquely identify this module GUID = '9d139310-ce45-41ce-8e8b-d76335aa1789' @@ -221,7 +221,7 @@ LicenseUri = "http://www.gnu.org/licenses/gpl-3.0.en.html" # Release notes for this particular version of the module - # ReleaseNotes = False + ReleaseNotes = "https://dbatools.io/releases" # If true, the LicenseUrl points to an end-user license (not just a source license) which requires the user agreement before use. # RequireLicenseAcceptance = ""