Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Closure Compiler #219

Open
m0hamm4dElmi opened this issue Aug 20, 2015 · 3 comments
Open

Google Closure Compiler #219

m0hamm4dElmi opened this issue Aug 20, 2015 · 3 comments

Comments

@m0hamm4dElmi
Copy link

Hi,
Thanks for this amazing plugin.
When I wanted to optimize above code by Google Closure Compiler, I encounter 25 warnings which is attached. Do you have any idea to remove these warnings?
https://www.dropbox.com/s/klvsc1w4w967kfx/fitvids.png?dl=0

Ward Regards

@davatron5000
Copy link
Owner

@m0hamm4dElmi Looks like you don't have jQuery. That's what I'd guess if $.fn is not defined.

@m0hamm4dElmi
Copy link
Author

Dear Davatron5000
I did not have any issue in working with fitdiv, in fact it works in perfect way. But I decide to minify it, when I’m trying to do that I encounter those mentioned errors (compressing in advanced mode shows the errors) that’s why I am bringing up this subject to see if there is a solution for it. I mean compressing in advanced mode with no warning. Hope to hear from you soon.

Best Regards

@davatron5000
Copy link
Owner

davatron5000 commented Jul 1, 2016

@m0hamm4dElmi Can I get some steps to reproduce this? Totally understandable if you've moved on over the past year 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants