Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CodeCommit accessable using a configured AWS profile #1431

Open
SpielerNogard opened this issue Dec 9, 2024 · 4 comments
Open

Make CodeCommit accessable using a configured AWS profile #1431

SpielerNogard opened this issue Dec 9, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@SpielerNogard
Copy link

Is your feature request related to a problem? Please describe.
Hey i wanted to try daytona, and was impressed, that i supports AWS CodeCommit, which is not supported by most other software. But since we are using AWS SSO, i would need support for already configured profiles from my machine.

Describe the solution you'd like
I would wish for instead of the need for configuring AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to just use my already configured AWS profile

@SpielerNogard SpielerNogard added the enhancement New feature or request label Dec 9, 2024
@Tpuljak
Copy link
Member

Tpuljak commented Dec 9, 2024

Hi @SpielerNogard,

Thanks for pointing this out.

We initialize the AWS CodeCommit client with default options.
From what I can see in the function definition, it should automatically load configured profiles.
Screenshot 2024-12-09 at 09 44 10

That being said, we might need to explicitly set the shared profile that should be loaded.

We could implement an additional environment variable (e.g. DAYTONA_AWS_SHARED_PROFILE) that you could set to the name of the profile that should be used. Then we could read that env and load the appropriate profile.
What do you think about that approach?

@SpielerNogard
Copy link
Author

Nice idea, would be a good start. But i would like to see it in the git-provider add command, that i can specify the profile name.

@SpielerNogard
Copy link
Author

And would also be nice if we can do the same for the AWS provider for workspaces

@Tpuljak
Copy link
Member

Tpuljak commented Dec 12, 2024

And would also be nice if we can do the same for the AWS provider for workspaces

Do you mind opening an issue for that on https://github.com/daytonaio/daytona-provider-aws?

Nice idea, would be a good start. But i would like to see it in the git-provider add command, that i can specify the profile name.

I suggest we start with the env var that both the server and provider can read. Also, adding such an exclusive property to a git provider will require more significant changes which we can implement at a later point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants