Skip to content
This repository has been archived by the owner on Jun 5, 2020. It is now read-only.

1.5.3 and previous are broken #46

Open
ktilcu opened this issue Jul 27, 2016 · 1 comment
Open

1.5.3 and previous are broken #46

ktilcu opened this issue Jul 27, 2016 · 1 comment

Comments

@ktilcu
Copy link

ktilcu commented Jul 27, 2016

It seems like the name of the downloaded jar has changed from compiler.jar to closure-compiler-v20160713.jar. The older versions of ClosureCompiler.js look for compiler.jar explicitly while 1.6.0looks for closure-compiler*. For users that specify their dependency on this library as ^1.5.3 or ~1.5.3, or any version below, the library doesn't work. It might make sense to pull in the jar finding code that was added in 1.6.0 to a 1.5.x minor so as not to break frozen builds.

This might not be the best solution and I'm sure you aren't totally in control of this but thought I would put it here for others.

@ktilcu
Copy link
Author

ktilcu commented Jul 27, 2016

I just noticed the deprecation message on the front page. This can serve for posterity I guess.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant