bootstrap_combo_nav_js middle button is always disabled

[MSeneadza]

I'm wondering if it's intentional for the middle button in the bootstrap_combo_nav_js to be disabled & non-editable by the user. Here's a screenshot of what I'm seeing in my app with Bootstrap 5.2.3:

I see from the screenshot here https://ddnexus.github.io/pagy/docs/extras/bootstrap/ that the page number field appears to be editable. It makes sense to me that the user should be able to enter a page number there and then hit ENTER to navigate to the entered page.

I modified this behavior in another app of mine by making my own version of the pagy_bootstrap_combo_nav_js method and simply removing the 'disabled' class from that input. I can certainly do that again but I just thought I'd ask if this is the intended behavior.

[benkoshy]

It's a known issue.

compatibility is broken across bootstrap versions.

[MSeneadza]

OK, thanks for the reply. I'll just change it locally again.

[ddnexus]

@benkoshy Then we should reopen #381

[ddnexus]

@benkoshy @MSeneadza

We could just edit this line

pagy/lib/pagy/extras/bootstrap.rb

Line 64 in 3f0aa6d

}<div class="pagy-combo-input btn btn-primary disabled" style="white-space: nowrap;">#{

changing btn-primary disabled to btn-secondary, and there should be no backward compatibility issues.

Could anyone post a screenshot of that applied change?

[ddnexus]

It works. I will commit it.

I will also restore the normal input text color (that in the screenshot is primary)

[ddnexus]

https://github.com/ddnexus/pagy/actions/runs/3910630563

[benkoshy]

Looks like an excellent solution. I had tried to retain the color but had failed.

[MSeneadza]

Seems like a great solution to me. Thanks!

[ddnexus]

Resolved in version 6.0.1