Validity checks

[deavmi]

textPass(ref string)

We should add two modes:

• Hardcore mode
  • Throws an exception on invalid message
• Easy mode
  • This will fix up messages for you and send them

Invalid can mean containing a CR or LF basically. So this would be an easy check.

What about Message's encode()?

Currently it does the same but on error throws an exception. Are we sure we want that behaviour?

[deavmi]

Look at:

• Strip any \n in messages sent and \r

[deavmi]

Been working on this now today and last few days.

[deavmi]

Leaving it running on Contabo to see how it fairs - doubt there are any bugs :)

[deavmi]

Gonna continue watching.

Only disconnects I had was a misconfigured release hook being handled by gitea-irc-bot's /commit handler causing it to crash and therefore birchwood IRCBot to exit. So not birchwood related....

[deavmi]

Added some unit tests

[deavmi]

Gonna continue watching.

Only disconnects I had was a misconfigured release hook being handled by gitea-irc-bot's /commit handler causing it to crash and therefore birchwood IRCBot to exit. So not birchwood related....

This seems fine ✔️

Honestly, a better test is with botty - so I will test with that tonight

[deavmi]

I have confirmed it works with botty and does strip ✔️

[deavmi]

Going to finish up and merge soon

[deavmi]

Added unit tests to test ChecksMode.EASY and ChecksMode.HARDCORE at the Message-level.

ChecksMode.EASY is confirmed at the Client level via Botty's stripping. I haven't tested the ChecksMode.HARDCORE in this case but it isn't default so it is fine and also, it probably works. Will add a test for it here.

[deavmi]

Okay, merging this now.