Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README details for integration test setup are out-of-date #13

Open
kindjar opened this issue Mar 23, 2017 · 2 comments
Open

README details for integration test setup are out-of-date #13

kindjar opened this issue Mar 23, 2017 · 2 comments

Comments

@kindjar
Copy link
Contributor

kindjar commented Mar 23, 2017

The docs currently suggest setting up a mapping like this:

var mapping = {
  '/people': {
    status: 201,
    body: { email: '[email protected]' }
  }
};

But the test server looks up mapping entries using the HTTP method plus the url path:

var mapped = mapping[request.method + " " + request.url];

The require path for the test server also appears to be wrong.

@mkdynamic
Copy link
Contributor

Looks like this PR is a fix? #11

@kindjar
Copy link
Contributor Author

kindjar commented Mar 23, 2017

Looks like there is a stub for the server, so that require path may not be an issue.

And yes, #11 looks like a fix for this. Though the existing example response body is also bit weird, and the value logged to the console isn't actually right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants