'Passed previous semester' crash if student has passed this semester

[torgeirl]

If a student has passed one or more assignment in the current semester the 'Passed previous semester' function crash when you try to pass them for all assignments they passed in previous semesters.

Solution
a. Add an error message warning that the student already passed some of the same assignments this semester, or
b. Make the function pass assignments previously passed if they haven't already passed this semester (again).

[StianJul]

@torgeirl, can't reproduce this. We should be filtering out students on the current semester that has been corrected, and is what's happening when trying to reproduce this error. Do you have any additional information?

Tested the following cases

Student passed assignment 1 current semester

1. Student has passed assignment1 on current semester.
2. The same student has passed assignment1 on previous semester.

Using the "Automatically pass students from an earlier semester" workflow and selecting the previous semester, results in the student being excluded from the selection of students that can be passed (since the student already has passed the assignment on the current semester)

Student passed assignment 1 and assignment 2 current semester

1. Student has passed assignment1 and assignment2 on current semester.
2. The same student has passed assignment1 and assignment2 on previous semester.

Same result here.

[torgeirl]

@StianJul: it will take me some time to get additional information on this issue. Moving this issue to the next feature release so it doesn't delay the release of 5.1.