Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitch with semester selection for automatic 'Passed previous semester' #1141

Open
torgeirl opened this issue Feb 21, 2020 · 0 comments
Open
Labels

Comments

@torgeirl
Copy link
Collaborator

Automatic 'Passed previous semester' seems to incorrectly combine results from multiple previous semesters when the older semester is selected from the wizard.

Steps to reproduce

  • Select 'Passed previous semester' on an assignment
  • Click 'Automatically pass students from an earlier semester'
  • When provided two options, they will produce different results:
    a) Selecting the newer semester, it will only find the matching assignment from that semester ✔️
    b) Selecting the older semester, it will find matching assignment from both the newer and older semester, and clicking 'Next' will show how it suggests applying results from both ❌

Given that the later works, this could actually be a good inclusion.

Suggested solution

  • Replace the radio buttons with check boxes, and allow admins to import results from passed semester from one or more semesters.
  • Make sure is actually gathers results from the selected semesters.
@torgeirl torgeirl added the bug label Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant