Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden table at bottom #1203

Open
torgeirl opened this issue Jan 7, 2022 · 2 comments
Open

Hidden table at bottom #1203

torgeirl opened this issue Jan 7, 2022 · 2 comments
Assignees
Labels
Milestone

Comments

@torgeirl
Copy link
Collaborator

torgeirl commented Jan 7, 2022

Below the footer, there is a meta class div element containing a hidden table:

  ...
</footer>
<div class="cfp-hotkeys-container fade ng-scope" ng-class="{in: helpVisible}" style="display: none;"> == $0
  <div class="cfp-hotkeys">
  ...
  <table>
    <tbody>
      ...

This could cause issues with screen readers, and should be avoided.

Edit: looks like the origin of this class is angular-hotkeys, added via cradmin_legacy.

@torgeirl torgeirl added the wcag label Jan 7, 2022
@torgeirl torgeirl added this to the Devilry 5.4 milestone Jan 12, 2022
@espenak espenak self-assigned this Jan 31, 2022
@espenak
Copy link
Member

espenak commented Jan 31, 2022

This is not easy to get rid of without the previously discussed project to replace angularjs @torgeirl. We could easily make this invisible with some hacks, but that would break the places where this is used for hotkeys support.

@torgeirl
Copy link
Collaborator Author

@espenak: OK, removing this from the current milestone awaiting an Angular replacement/upgrade.

@torgeirl torgeirl removed this from the Devilry 5.4 milestone Jan 31, 2022
@torgeirl torgeirl changed the title Hidden table at buttom Hidden table at bottom Jan 15, 2024
@torgeirl torgeirl added this to the Devilry 6.4 milestone Jan 30, 2024
@torgeirl torgeirl modified the milestones: Devilry 6.4, Devilry 6.5 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants