Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RQ Worker timeout doesn't yield an error #1310

Open
torgeirl opened this issue Aug 15, 2024 · 1 comment
Open

RQ Worker timeout doesn't yield an error #1310

torgeirl opened this issue Aug 15, 2024 · 1 comment
Labels
Milestone

Comments

@torgeirl
Copy link
Collaborator

torgeirl commented Aug 15, 2024

If a batchframework_admin_compress_assignment operation fails due to a timeout caused by the task to build a Tar archive file exceeding the timeout set by RQ_QUEUES['default']['DEFAULT_TIMEOUT'], the failure is only reflected by the status in the Django admin UI.

Status: finished
Result: failed
Output: 
{"actiongroup_name": "batchframework_admin_compress_assignment",
  "results": [{
    "action_name": "devilry.devilry_admin.tasks.AssignmentCompressAction",
    "failed": true, "errordata": {
      "data": "An HTTP Client raised an unhandled exception: Task exceeded maximum timeout value (500 seconds)"
      ...

The timeout does not yield an error (so it could be detected by Sentry), and the RQ worker itself just logs «Job OK»:

[INFO] rq.worker: default: ievv_opensource.ievv_batchframework.rq_tasks.default(
    actiongroup_name='batchframework_admin_compress_assignment',
    batchoperation_id=<batch-operation-ID>,
    operationtype='batchframework_admin_compress_assignment') (<job-hash>)
[INFO] rq.worker: default: Job OK (<job-hash>)
@torgeirl torgeirl added this to the Devilry 6.4 milestone Aug 15, 2024
@torgeirl torgeirl added the bug label Aug 15, 2024
@torgeirl torgeirl changed the title RQ timeout doesn't yield an error RQ Worker timeout doesn't yield an error Aug 15, 2024
@torgeirl torgeirl modified the milestones: Devilry 6.4, Devilry 6.5 Dec 3, 2024
@torgeirl torgeirl modified the milestones: Devilry 6.5, Devilry 6.4 Feb 5, 2025
@torgeirl
Copy link
Collaborator Author

torgeirl commented Feb 5, 2025

Partly addressed in b868acb (doesn't cover timeout, but issues like #1322).

@torgeirl torgeirl modified the milestones: Devilry 6.4, Devilry 6.5 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant