Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI/UX Issues in Docker Compose and Helm Template Pages #134

Merged
merged 10 commits into from
Dec 8, 2024

Conversation

MiladSadeghi
Copy link
Contributor

This PR addresses multiple UI/UX issues in the Docker Compose and Helm Template pages of the web app. The changes improve user experience and resolve layout inconsistencies.

Closes #133

…avior

- Refactor the Docker Compose form to enhance UI/UX for better user experience.
- Fix the `useDownload` hook to ensure the file downloads correctly after a page reload.
- Clean up and improve the code on the Docker Compose page, addressing various issues.
- Fixes an incorrect shadow rendering on the select box when in light mode.
- Refactor the Helm template form to enhance user interface and user experience.
@github-actions github-actions bot added the web-ui label Dec 7, 2024
…ild fields

- Ensure the image field is required only when the build option is disabled in Docker Compose.
- When the build option is enabled, make the build-related fields required and allow the image field to be optional.
- Prevent sending empty strings to the server; send null instead.
@abolfazl8131
Copy link
Contributor

please fix there problems in docker compose route:

  1. version field is required
  2. network name is required is use non-costum
  3. all fields of custom network are required
  4. don't send any empty string at all. (just null or the value)

@MiladSadeghi
Copy link
Contributor Author

@abolfazl8131 Thanks for the feedback! I’ve made the necessary changes.

@mohammadll
Copy link
Contributor

@MiladSadeghi Thank you! The new changes are working well. However, there are a few adjustments that need to be made.

As you know, our UI now has two types of networks: non-custom and custom. Here are the required changes:

The non-custom network should be optional.

  • Changes to the custom network:
    • Update the button name from Custom to External Network.
    • When the user clicks the "External Network" button (currently labeled as "Custom"), there should not be an additional button named "External Network" appearing inside the network settings. This extra button is unnecessary and should be removed.

- Remove individual external network switch for each network.
- Allow all networks to be marked as external or to have a driver, streamlining the configuration
@mohammadll mohammadll merged commit f1c9877 into devopshobbies:master Dec 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI/UX Issues in Docker Compose and Helm Template Pages
3 participants