Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Verification + Google / Github SSO for Web #21

Closed
matthewwong525 opened this issue Mar 5, 2024 · 1 comment · Fixed by #34
Closed

Email Verification + Google / Github SSO for Web #21

matthewwong525 opened this issue Mar 5, 2024 · 1 comment · Fixed by #34

Comments

@matthewwong525
Copy link
Collaborator

matthewwong525 commented Mar 5, 2024

  • Sending emails and it's bouncing because email is not verified. Add email verification! Basically after they sign up, change to sign in and shoot a dialog telling user to verify their email.
  • Ensure to only send emails to verified users! So maybe if email_verified_at is not null. or something along those lines. (double check that this works with SSO)
  • Update UI so that it optimizes for using SSO (effectively hiding the email form). The goal is to drive more people to use SSO because it is better.
  • Update docs to teach people how to do SSO or at the very least remove the construction stuff in the README

Will NOT DO:

@matthewwong525 matthewwong525 changed the title Add guides for SSO Email Verification + Google / Github SSO Mar 9, 2024
@matthewwong525
Copy link
Collaborator Author

matthewwong525 commented Mar 9, 2024

Doing this because:

  • Unverified emails affect email deliverability and it's key to have good deliverability so emails don't hit spam
  • SSO is easier for the user and increases conversion rate!

This was referenced Mar 12, 2024
@matthewwong525 matthewwong525 changed the title Email Verification + Google / Github SSO Email Verification + Google / Github SSO for Web Mar 12, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in devtodollars tasks Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant