From f955f5f6c191accf058451cd7f22354358fd325d Mon Sep 17 00:00:00 2001 From: dfahlander Date: Mon, 18 Dec 2023 10:35:47 +0100 Subject: [PATCH] Now that all 3 browser engines are tested in CI on Lambdatest, we don't really need to run them again in the release script. However, for safety, run them locally on Chrome and Firefox still. --- test/karma.browsers.matrix.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/karma.browsers.matrix.js b/test/karma.browsers.matrix.js index d90fc92d5..522641d4b 100644 --- a/test/karma.browsers.matrix.js +++ b/test/karma.browsers.matrix.js @@ -8,7 +8,6 @@ module.exports = { // On developers machines, Chrome is most likely to be installed. local: ['Chrome'], - //local: ['bs_safari_latest_supported'], // When Lambdatest credentials aren't available, use Chrome and Firefox on Github Actions: ciLocal: ['Chrome', 'Firefox'], @@ -21,11 +20,13 @@ module.exports = { ], // Test matrix used before every npm publish. + // Note: The script tools/release.sh will run the tests + // locally on Chrome and Firefox. However, this is just an + // extra safety check as all tests must anyway have been successful + // on the CI that tests on all configured browsers in Lambdatest. pre_npm_publish: [ - 'remote_chrome', - 'remote_edge', - 'remote_safari', - 'remote_firefox' + 'Chrome', + 'Firefox' ] }