From 48056c762e1e8565a41c50ac25fd0e85d8d6f23c Mon Sep 17 00:00:00 2001 From: PlanB Date: Fri, 8 May 2020 02:50:50 +0900 Subject: [PATCH] [0.0.2.5] Add reviewId to returns of reviews function --- .gitignore | 1 + CHANGES.md | 10 +++++++++- google_play_scraper/__init__.py | 2 +- tests/e2e_tests/test_reviews.py | 2 ++ 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 62b28cd..47f0ced 100644 --- a/.gitignore +++ b/.gitignore @@ -270,3 +270,4 @@ $RECYCLE.BIN/ # End of https://www.gitignore.io/api/macos,python,windows,pycharm+all test.py +tmp.py diff --git a/CHANGES.md b/CHANGES.md index b5028f5..7ac41f0 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -54,9 +54,17 @@ ## v0.0.2.2 > `reviews` feature improvement -- New property `replyContent`, `repliedAt` Added. +- New property `replyContent`, `repliedAt` added. - Fix bug of `reivews` feature : Bug that occurs when the total number of reviews is less than the `count` argument. ## v0.0.2.3 > Added `continuation_token` as return value, argument of `reviews` feature - New return value, argument `contination_token` added to `reviews` function. It will be helped to lazy pagination patterns. + +## v0.0.2.4 +> Added argument data to `continuation_token` of `reviews` feature +- Objectify `continuation_token` for saving arguments + +## v.0.0.2.5 +> `reviews` feature improvement +- New property `reviewId` added to `reviews` function. diff --git a/google_play_scraper/__init__.py b/google_play_scraper/__init__.py index 61bdcaa..711b9b4 100644 --- a/google_play_scraper/__init__.py +++ b/google_play_scraper/__init__.py @@ -2,4 +2,4 @@ from .features.app import app from .features.reviews import reviews -__version__ = "0.0.2.4" +__version__ = "0.0.2.5" diff --git a/tests/e2e_tests/test_reviews.py b/tests/e2e_tests/test_reviews.py index 58cbd3a..fe50561 100644 --- a/tests/e2e_tests/test_reviews.py +++ b/tests/e2e_tests/test_reviews.py @@ -23,6 +23,8 @@ def test_e2e_scenario_1(self): review_created_version_contained_review_count = 0 for r in result: + self.assertTrue(r["reviewId"].startswith("gp:AOqp")) + self.assertTrue(len(r["reviewId"]) == 90) self.assertTrue(r["userName"]) self.assertTrue(r["userImage"]) self.assertTrue(r["content"])