New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a risk of SQL injection. #32

Open

QiAnXinCodeSafe opened this issue May 13, 2021 · 1 comment

QiAnXinCodeSafe commented May 13, 2021

DDMQ/rocketmq/broker/src/main/java/org/apache/rocketmq/broker/transaction/jdbc/JDBCTransactionStore.java

Line 128 in 2f30b61

statement.execute(sql);

It is recommended to replace java.sql.Statement with java.sql.PreparedStatement.

Collaborator

Jason918 commented Jun 11, 2021

DDMQ/rocketmq/broker/src/main/java/org/apache/rocketmq/broker/transaction/jdbc/JDBCTransactionStore.java

Line 128 in 2f30b61

statement.execute(sql);

It is recommended to replace java.sql.Statement with java.sql.PreparedStatement.

You are right, thank you for your suggestion.

SchopenhauerZhang mentioned this issue

bgfix sql injection #36

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment