Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all dependencies #68

Closed
wants to merge 2 commits into from

Conversation

JulioJu
Copy link

@JulioJu JulioJu commented Oct 16, 2019

Upgrade all dependencies to try to fix #67

  • correct typescript errors
  • do not correct Elm errors (actually broken)

Note that the pull request #66 is already pushed

JulioJu added 2 commits October 16, 2019 17:07
Fix dillonkearns#65

Notes:
  * Deprecation of `app.makeSingleInstance` https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#appmakesingleinstance
  * On Arch Linux with OpenBox, `app.dock` is `undefined`
  * Version 1.8.2 of Electron crashes with `Harfbuzz version too old`, but
    not Electron 1.8.3
  * correct typescript errors
  * do not correct Elm errors
@JulioJu
Copy link
Author

JulioJu commented Oct 16, 2019

Hi !

I don't know Elm. When we upgrade, there are lot of Elm errors. Could you help me please to finish this PR ?

I don't know if it will fix #67 , but it's possible. With Electron 5.0.0 and later, when we open dev tools in Electron we see errors about Webpack. When we upgrade Webpack we need to upgrade TypeScript. And upgrade TypeScript seems to cause problems with the module ./src/Timer/Timer.elm And when we upgrade to Elm 0.19, we have errors with Elm, don't know why.

Note that a file named elm.json is created with the upgrade to Elm 0.19. Is it correctly created?

Thanks in advance !

@dillonkearns
Copy link
Owner

Upgrading Elm is blocked on one of the dependencies not being updated. It's a huge change, I had it going in a branch but got stuck on that issue.

But there's no need to change the Elm version in order to upgrade the Electron binary, so that should be a separate change. If you can get the app working with the latest Electron and work through the issues there then I will merge that in!

@JulioJu
Copy link
Author

JulioJu commented Oct 16, 2019

@dillonkearns ok so cool, thanks !

I was frustrated to not upgrade to the last version of Electron, therefore I have done some tests.

I suppose it's caused of Elm, but you say it's not the problem ?

With d444cbc and the following packjage.json (all upgraded except Elm, that is on version 0.18). (note that " elm-webpack-loader": "^4.4.0 cause problems, therfore I use version 6).

  "devDependencies": {
    "@types/jquery": "^3.3.31",
    "@types/node": "^12.11.1",
    "@types/universal-analytics": "^0.4.2",
    "@types/webpack": "^4.39.3",
    "concurrently": "^5.0.0",
    "devtron": "^1.4.0",
    "electron": "6.0.12",
    "electron-builder": "21.2.0",
    "elm": "^0.18.0",
    "elm-electron": "0.0.3",
    "elm-hot-loader": "^0.5.4",
    "elm-test": "^0.18.12",
    "elm-webpack-loader": "^6.0.0",
    "ts-loader": "^6.2.0",
    "ts-node": "^8.4.1",
    "typescript": "3.6.4",
    "webpack": "^4.41.2",
    "webpack-cli": "^3.3.9",
    "webpack-dev-server": "^3.8.2"
  },
  "dependencies": {
    "bugsnag": "^2.1.3",
    "clipboard": "^2.0.4",
    "electron-debug": "^3.0.1",
    "electron-is-dev": "^1.1.0",
    "electron-log": "^3.0.8",
    "electron-updater": "^4.1.2",
    "highlight.js": "^9.10.0",
    "jquery": "^3.3.1",
    "machine-uuid": "^1.2.0",
    "ms": "^2.1.1",
    "node-osascript": "^2.0.0",
    "universal-analytics": "^0.4.16"
  }

I have the TypeScript error

[1] typescript/timer.ts(1,7): error TS2403: Subsequent variable declarations must have the same type.  Variable 'Elm' must be of type 'typeof import("/tmp/mobster/src/Setup/Main/index")', but

I don't understand why, and I'm frustrated. I thought is caused by Elm 0.18.

Ok, I close this PR, and let you #67 to be merged, if you want.

@JulioJu JulioJu closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug fatal with Electron 5.0.0 and newer
2 participants