Update store paths to require numbers for indices #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d17f38e:
|
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
- Coverage 98.07% 98.04% -0.03%
==========================================
Files 120 120
Lines 6634 6647 +13
Branches 1508 1520 +12
==========================================
+ Hits 6506 6517 +11
- Misses 128 130 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
This could move the store "paths" away from a JSON path style implementation and instead explicitly require numeric values to access array indices. Any string would be treated as an object property. Of course, if the targeted value is already an array passing a string would still work to index the array, but it would only use regular property access and not array methods.
This would resolve #645 but it'd also be a breaking change.